Conversation
github-actions
bot
added
📖 Project documentation
|
View your CI Pipeline Execution ↗ for commit 54195ec
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/models
@code-pushup/nx-plugin
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
# Conflicts: # packages/utils/docs/profiler.md # packages/utils/src/lib/profiler/constants.ts # packages/utils/src/lib/profiler/profiler.int.test.ts # packages/utils/src/lib/profiler/profiler.ts # packages/utils/src/lib/profiler/profiler.unit.test.ts
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 49 out of 49 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@BioPhoton I've opened a new pull request, #1232, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@BioPhoton I've opened a new pull request, #1233, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 49 out of 49 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export type RecoverResult<T> = { | ||
| /** Successfully recovered records */ | ||
| records: T[]; | ||
| records: (T | InvalidEntry)[]; | ||
| /** Errors encountered during recovery with line numbers and context */ |
There was a problem hiding this comment.
RecoverResult.records is typed as (T | InvalidEntry)[], but InvalidEntry is generic and the raw type is effectively string for file-backed WALs (and InvalidEntry<string> is already used elsewhere in this file). Consider changing this to (T | InvalidEntry<string>)[] (or parameterizing RecoverResult with the raw type) to avoid losing type information and to keep RecoverResult consistent with WriteAheadLogFile.recover() / WalStats.lastRecovery types.
Related:
@cursor review